Skip to content

feat: eip712 type hash #10483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

feat: eip712 type hash #10483

wants to merge 6 commits into from

Conversation

0xrusowsky
Copy link
Contributor

Adds a new cheatcode to safely generate hashes following the EIP-712 spec.

implementation details

As highlighted on:

due to the lack of polymorphism, it is not possible for the cheatcode to accept a struct. Because of that, users must provide a string.

This initial impl requires users to input the full string representation of the type (later on we can iterate and attempt to figure the type from the artifact).

Users are not required to pass sorted types, and can also add spaces after commas. See the test cases for a better understanding:

// CANONICAL TYPE
bytes32 constant _PERMIT_SINGLE_TYPEHASH = keccak256(
    "PermitSingle(PermitDetails details,address spender,uint256 sigDeadline)PermitDetails(address token,uint160 amount,uint48 expiration,uint48 nonce)"
);

function test_canHashCanonicalTypes() public {
    typeHash = vm.eip712HashType(
        "PermitSingle(PermitDetails details,address spender,uint256 sigDeadline)PermitDetails(address token,uint160 amount,uint48 expiration,uint48 nonce)"
    );
    assertEq(typeHash, _PERMIT_SINGLE_TYPEHASH);
}

function test_canHashMessyTypes() public {
    typeHash = vm.eip712HashType(
        "PermitDetails(address token, uint160 amount, uint48 expiration, uint48 nonce) PermitSingle(PermitDetails details, address spender, uint256 sigDeadline)"
    );
    assertEq(typeHash, _PERMIT_SINGLE_TYPEHASH);
}

@0xrusowsky 0xrusowsky self-assigned this May 9, 2025
@0xrusowsky 0xrusowsky added the A-cheatcodes Area: cheatcodes label May 9, 2025
@0xrusowsky 0xrusowsky requested a review from zerosnacks as a code owner May 9, 2025 16:16
@0xrusowsky 0xrusowsky linked an issue May 9, 2025 that may be closed by this pull request
Cheatcode: EIP712 canonical hashing #4818
Open
0xrusowsky
0xrusowsky commented May 9, 2025
View reviewed changes
mattsse
mattsse reviewed May 10, 2025
View reviewed changes
@grandizzy grandizzy marked this pull request as draft May 13, 2025 12:30
@0xrusowsky 0xrusowsky removed a link to an issue May 20, 2025
Cheatcode: EIP712 canonical hashing #4818
Open
@0xrusowsky 0xrusowsky removed this from Foundry May 20, 2025
@0xrusowsky 0xrusowsky closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees

@0xrusowsky 0xrusowsky

Labels
A-cheatcodes Area: cheatcodes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xrusowsky @mattsse